fix: guard null selected item during item tool placement#229
Merged
open-pascal merged 1 commit intomainfrom Apr 14, 2026
Merged
fix: guard null selected item during item tool placement#229open-pascal merged 1 commit intomainfrom
open-pascal merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
item-tool.tsxWhy
This ports the recent monorepo fix from Anton (
174246fb,fix(editor): guard null asset in usePlacementCoordinator).The OSS editor still had the older partial guard, but it was still assuming
selectedItem!initem-tool.tsxand still running placement coordinator effects/frames when the asset was null. That can happen during transient tool activation or scene updates and can cascade into render failures.Verification
npx -y @biomejs/biome check packages/editor/src/components/tools/item/item-tool.tsx packages/editor/src/components/tools/item/use-placement-coordinator.tsxnpx -y react-doctor@latest . --verbose --diff(packages/editor scored 99/100, warning-only on pre-existing unknown properties inuse-placement-coordinator.tsx)